optimize FidelityQuantumKernel parameterization
#719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoritzWillmann
requested review from
stefan-woerner,
woodsp-ibm and
adekusar-drl
as code owners
|
Can you please measure how faster the implementation becomes with this PR? |
Pull Request Test Coverage Report for Build 7049710944
💛 - Coveralls |
This is the runtime of the respective functions in seconds as benchmarked with |
|
Thanks, this is interesting. Can you please additionally measure an overall impact on |
|
With |
Co-authored-by: Anton Dekusar <[email protected]>
MoritzWillmann
commented
Nov 28, 2023
adekusar-drl
approved these changes
Nov 30, 2023
oscar-wallis
pushed a commit
that referenced
this pull request
Feb 16, 2024
* optimize fqk parameterization * Update qiskit_machine_learning/kernels/fidelity_quantum_kernel.py Co-authored-by: Anton Dekusar <[email protected]> * Update qiskit_machine_learning/kernels/fidelity_quantum_kernel.py * remove vstack --------- Co-authored-by: Anton Dekusar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the way
indices,right_parametersandleft_parametersare created in_get_symmetric_parameterizationand_get_parameterizationof theFidelityQuantumKernelclass.Details and comments
The previous version used a heavy amount of dynamic memory allocation which resulted in a very long runtime. This new version runs way faster for bigger instances by not using dynamic memory allocation. I didn't add any additional tests, since this doesn't introduce any new functionality.
I'm happy to incorporate comments and hope this can be merged soon 😄